Imported Upstream version 3.0.4upstream/3.0.4

2 files changed, 15 insertions, 4 deletions

diff --git a/SQLiteStudio3/coreSQLiteStudio/services/impl/dbmanagerimpl.cpp b/SQLiteStudio3/coreSQLiteStudio/services/impl/dbmanagerimpl.cpp
index 70aa568..e96e181 100644
--- a/SQLiteStudio3/coreSQLiteStudio/services/impl/dbmanagerimpl.cpp
+++ b/SQLiteStudio3/coreSQLiteStudio/services/impl/dbmanagerimpl.cpp
@@ -107,9 +107,14 @@ bool DbManagerImpl::updateDb(Db* db, const QString &name, const QString &path, c
         result = CFG->removeDb(name);
 
     InvalidDb* invalidDb = dynamic_cast<InvalidDb*>(db);
+    bool wasReloaded = false;
     Db* reloadedDb = db;
     if (pathDifferent && invalidDb)
-        reloadedDb = tryToLoadDb(invalidDb);
+    {
+        reloadedDb = tryToLoadDb(invalidDb, false);
+        if (reloadedDb) // we need to know that, so we can emit dbLoaded() signal later, out of the listLock
+            wasReloaded = true;
+    }
 
     if (reloadedDb) // reloading was not necessary (was not invalid) or it was successful
         db = reloadedDb;
@@ -119,6 +124,10 @@ bool DbManagerImpl::updateDb(Db* db, const QString &name, const QString &path, c
 
     listLock.unlock();
 
+    // If we did reload the db, we need to emit proper signal, because it was suppressed in tryToLoadDb(), because of the listLock
+    if (wasReloaded)
+        emit dbLoaded(db);
+
     if (result && reloadedDb)
         emit dbUpdated(oldName, db);
     else if (reloadedDb) // database reloaded correctly, but update failed
@@ -355,7 +364,7 @@ QList<Db*> DbManagerImpl::getInvalidDatabases() const
     });
 }
 
-Db* DbManagerImpl::tryToLoadDb(InvalidDb* invalidDb)
+Db* DbManagerImpl::tryToLoadDb(InvalidDb* invalidDb, bool emitNotifySignal)
 {
     QUrl url = QUrl::fromUserInput(invalidDb->getPath());
     if (url.isLocalFile() && !QFile::exists(invalidDb->getPath()))
@@ -373,7 +382,9 @@ Db* DbManagerImpl::tryToLoadDb(InvalidDb* invalidDb)
     if (CFG->getDbGroup(db->getName())->open)
         db->open();
 
-    emit dbLoaded(db);
+    if (emitNotifySignal)
+        emit dbLoaded(db);
+
     return db;
 }
 
diff --git a/SQLiteStudio3/coreSQLiteStudio/services/impl/dbmanagerimpl.h b/SQLiteStudio3/coreSQLiteStudio/services/impl/dbmanagerimpl.h
index 8e28080..5797ac6 100644
--- a/SQLiteStudio3/coreSQLiteStudio/services/impl/dbmanagerimpl.h
+++ b/SQLiteStudio3/coreSQLiteStudio/services/impl/dbmanagerimpl.h
@@ -94,7 +94,7 @@ class API_EXPORT DbManagerImpl : public DbManager
          */
         QList<Db*> getInvalidDatabases() const;
 
-        Db* tryToLoadDb(InvalidDb* invalidDb);
+        Db* tryToLoadDb(InvalidDb* invalidDb, bool emitNotifySignal = true);
 
         /**
          * @brief Creates database object.