diff options
author | Unit 193 <unit193@ubuntu.com> | 2019-01-25 21:58:53 -0500 |
---|---|---|
committer | Unit 193 <unit193@ubuntu.com> | 2019-01-25 21:58:53 -0500 |
commit | 16dd018ca735392c2fb28b986316a9b22a06ccf9 (patch) | |
tree | c85d59074c078408e4032be4420b0af863ec16b0 | |
parent | dddfa903d2b856146f05ffb4415c31d6127bb5bf (diff) | |
download | ruby-roo-upstream/2.8.1.tar.bz2 ruby-roo-upstream/2.8.1.tar.xz ruby-roo-upstream/2.8.1.tar.zst |
New upstream version 2.8.1upstream/2.8.1
-rw-r--r-- | CHANGELOG.md | 8 | ||||
-rwxr-xr-x | lib/roo/excelx/sheet_doc.rb | 2 | ||||
-rw-r--r-- | lib/roo/version.rb | 2 | ||||
-rw-r--r-- | spec/lib/roo/excelx/sheet_doc_spec.rb | 11 | ||||
-rw-r--r-- | test/files/blank_children.xlsx | bin | 0 -> 4465 bytes |
5 files changed, 20 insertions, 3 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index d93da95..c0c4a39 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,10 @@ -## Unreleased +## Unreleased + +## [2.8.1] 2019-01-21 +### Fixed +- Fixed error if excelx's cell have empty children [487](https://github.com/roo-rb/roo/pull/487) + +## [2.8.0] 2019-01-18 ### Fixed - Fixed inconsistent column length for CSV [375](https://github.com/roo-rb/roo/pull/375) - Fixed formatted_value with `%` for Excelx [416](https://github.com/roo-rb/roo/pull/416) diff --git a/lib/roo/excelx/sheet_doc.rb b/lib/roo/excelx/sheet_doc.rb index 8b0c686..2b3aa39 100755 --- a/lib/roo/excelx/sheet_doc.rb +++ b/lib/roo/excelx/sheet_doc.rb @@ -120,7 +120,7 @@ module Roo end end - create_empty_cell(coordinate) + create_empty_cell(coordinate, empty_cell) end def create_empty_cell(coordinate, empty_cell) diff --git a/lib/roo/version.rb b/lib/roo/version.rb index 7fd96d7..625e495 100644 --- a/lib/roo/version.rb +++ b/lib/roo/version.rb @@ -1,3 +1,3 @@ module Roo - VERSION = "2.8.0" + VERSION = "2.8.1" end diff --git a/spec/lib/roo/excelx/sheet_doc_spec.rb b/spec/lib/roo/excelx/sheet_doc_spec.rb new file mode 100644 index 0000000..3dc3e93 --- /dev/null +++ b/spec/lib/roo/excelx/sheet_doc_spec.rb @@ -0,0 +1,11 @@ +# frozen_string_literal: true + +require "spec_helper" + +describe Roo::Excelx::SheetDoc do + subject(:blank_children) { Roo::Excelx.new("test/files/blank_children.xlsx") } + + example "#last_row" do + expect(subject.last_row).to eq 3 + end +end diff --git a/test/files/blank_children.xlsx b/test/files/blank_children.xlsx Binary files differnew file mode 100644 index 0000000..a495849 --- /dev/null +++ b/test/files/blank_children.xlsx |